ARTEMIS-6049 mask cluster-password input from CLI#6419
Merged
clebertsuconic merged 1 commit intoapache:mainfrom May 8, 2026
Merged
ARTEMIS-6049 mask cluster-password input from CLI#6419clebertsuconic merged 1 commit intoapache:mainfrom
clebertsuconic merged 1 commit intoapache:mainfrom
Conversation
jbertram
force-pushed
the
ARTEMIS-6049
branch
2 times, most recently
from
80fe3e9 to
5b70409
Compare
| if (clusterPassword == null) { | ||
| clusterPassword = inputPassword("--cluster-password", "What is the cluster password?", "password-admin"); | ||
| try { | ||
| clusterPassword = PasswordMaskingUtil.wrap(PasswordMaskingUtil.getDefaultCodec().encode(clusterPassword)); |
Contributor
There was a problem hiding this comment.
@jbertram I don't understand this.. you're only masking the password if sent through the input..
I think if you did ./artemis create --cluster --password myPassowrd
it should also be masked, right?
Contributor
There was a problem hiding this comment.
as a matter of fact there are a few smoke tests (e.g. ClsuteredLargeMessageTest) that will use the clustered CLI, and it would be a good test basis.
| Create.enableInput(); | ||
| try { | ||
| InputReader inputReader = Mockito.mock(InputReader.class); | ||
| Mockito.when(inputReader.readPassword(Mockito.anyString())).thenReturn(password); |
Contributor
There was a problem hiding this comment.
you should also test when through arguments.. (non masked)..
so it doesn't matter to use the input here.. you could just always mask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.